Messages in this thread | | | Date | Tue, 18 Dec 2007 14:58:56 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/4] x86: add kprobe-booster to X86_64 |
| |
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> On Tue, 2007-12-18 at 12:29 +0100, Ingo Molnar wrote: > > * Harvey Harrison <harvey.harrison@gmail.com> wrote: > > > > > Sorry I missed an ifdef in this patch in the following hunk: > > > > could you resend your kprobes cleanups against current x86.git? They > > have been conceptually acked by Masami. This cuts out the unification > > part of your queue which is bad luck but the effort has been duplicated > > already so there's not much we can do about it i guess. > > > > Your other 17 cleanup and unification patches are still queued up in > > x86.git and passed a lot of testing, so they will likely go into > > v2.6.25. Nice work! > > > > Ingo > > Ingo, > > I'd suggest just tossing my kprobes cleanups. I just sent you a rollup > of anything I saw that was left in mine that was still worthwhile > after Masami's, included below for reference. It didn't amount to much > left so I rolled it all together: > > Subject: [PATCH] x86: kprobes leftover cleanups > > Eliminate __always_inline, all of these static functions are > only called once. Minor whitespace cleanup. Eliminate one > supefluous return at end of void function. Reverse sense of > #ifndef to be #ifdef to show the case only affects X86_32.
thanks, i've applied them.
Ingo
| |