lkml.org 
[lkml]   [2007]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [RFC] be more verbose when probing EDD
    Alan Cox wrote:
    >> Does printk support escape sequences? The last time I tried
    >> printk("\e[1;35m omg ponies \e[0m"); that did not went too successful.
    >
    > It should handle \r correctly. If not that is easy to fix.
    >
    > Escape codes are bad and should not be used - you may have a serial
    > console and not be on a Linux console

    It's not printk(), or the console, that's the issue...
    Consider logging to a file, which is quite common.

    Dumping formatting characters in there is a bit evil.

    Instead of using \r and overwrite, something like

    Testing foo... ok

    printk(KERN_INFO "Testing foo... ");
    foo();
    printk("ok\n");

    ... really is a lot better. We used to do that a lot more.

    -hpa


    \
     
     \ /
      Last update: 2007-12-18 01:25    [W:0.022 / U:29.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site