lkml.org 
[lkml]   [2007]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PACKET]: Fix /proc/net/packet crash due to bogus private pointer
    On Sun, Dec 16, 2007 at 11:07:07AM +0800, Herbert Xu wrote:
    >
    > I suspect namespace borkage. But just because you pin-pointed
    > my patch I'll try to track it down :)

    Surprise surprise. The namespace seq patch missed two spots in
    AF_PACKET.

    [PACKET]: Fix /proc/net/packet crash due to bogus private pointer

    The seq_open_net patch changed the meaning of seq->private.
    Unfortunately it missed two spots in AF_PACKET, which still
    used the old way of dereferencing seq->private, thus causing
    weird and wonderful crashes when reading /proc/net/packet.

    This patch fixes them.

    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

    diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
    index 485af56..43e49f4 100644
    --- a/net/packet/af_packet.c
    +++ b/net/packet/af_packet.c
    @@ -1878,7 +1878,7 @@ static void *packet_seq_start(struct seq_file *seq, loff_t *pos)

    static void *packet_seq_next(struct seq_file *seq, void *v, loff_t *pos)
    {
    - struct net *net = seq->private;
    + struct net *net = seq_file_net(seq);
    ++*pos;
    return (v == SEQ_START_TOKEN)
    ? sk_head(&net->packet.sklist)
    @@ -1887,7 +1887,7 @@ static void *packet_seq_next(struct seq_file *seq, void *v, loff_t *pos)

    static void packet_seq_stop(struct seq_file *seq, void *v)
    {
    - struct net *net = seq->private;
    + struct net *net = seq_file_net(seq);
    read_unlock(&net->packet.sklist_lock);
    }

    Cheers,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

    \
     
     \ /
      Last update: 2007-12-16 04:45    [W:0.022 / U:158.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site