Messages in this thread | | | Date | Fri, 14 Dec 2007 13:30:14 -0500 | From | Mark Lord <> | Subject | Re: [PATCH] fix page_alloc for larger I/O segments (improved) |
| |
Matthew Wilcox wrote: > On Fri, Dec 14, 2007 at 05:42:37PM +0000, Mel Gorman wrote: >> Regrettably this interferes with anti-fragmentation because the "next" page >> on the list on return from rmqueue_bulk is not guaranteed to be of the right >> mobility type. I fixed it as an additional patch but it adds additional cost >> that should not be necessary and it's visible in microbenchmark results on >> at least one machine. > > Is this patch to be preferred to the one Andrew Morton posted to do > list_for_each_entry_reverse? ..
This patch replaces my earlier patch that Andrew has:
- list_add(&page->lru, list); + list_add_tail(&page->lru, list);
Which, in turn, replaced the even-earlier list_for_each_entry_reverse patch.
-ml
| |