Messages in this thread | | | Date | Thu, 13 Dec 2007 14:34:25 -0800 (PST) | Subject | Re: [RFC] net: napi fix | From | David Miller <> |
| |
From: Jarek Poplawski <jarkao2@gmail.com> Date: Thu, 13 Dec 2007 23:28:41 +0100
> ...I'm afraid I can't understand: I mean doing the same but without > passing this info with 'work == weight': if driver sends this info, > why it can't instead call something like napi_continue() with > this list_move_tail() (and probably additional local_irq_disable()/ > enble() - but since it's unlikely()?) which looks much more readable, > and saves one whole unlikely if ()?
Because the poll list is private to net_rx_action() and we don't want to expose implementation details like that to every ->poll() implementation.
| |