Messages in this thread Patch in this message | | | Date | Wed, 12 Dec 2007 22:35:34 -0800 | From | Greg KH <> | Subject | [patch 34/36] NETFILTER: xt_TCPMSS: remove network triggerable WARN_ON |
| |
2.6.22-stable review patch. If anyone has any objections, please let us know.
------------------ From: Patrick McHardy <kaber@trash.net>
[NETFILTER]: xt_TCPMSS: remove network triggerable WARN_ON
[ Upstream commit: 9dc0564e862b1b9a4677dec2c736b12169e03e99 ]
ipv6_skip_exthdr() returns -1 for invalid packets. don't WARN_ON that.
Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- net/netfilter/xt_TCPMSS.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
--- a/net/netfilter/xt_TCPMSS.c +++ b/net/netfilter/xt_TCPMSS.c @@ -178,10 +178,8 @@ xt_tcpmss_target6(struct sk_buff **pskb, nexthdr = ipv6h->nexthdr; tcphoff = ipv6_skip_exthdr(*pskb, sizeof(*ipv6h), &nexthdr); - if (tcphoff < 0) { - WARN_ON(1); + if (tcphoff < 0) return NF_DROP; - } ret = tcpmss_mangle_packet(pskb, targinfo, tcphoff, sizeof(*ipv6h) + sizeof(struct tcphdr)); if (ret < 0) --
| |