Messages in this thread | | | Date | Thu, 13 Dec 2007 06:19:38 -0800 (PST) | Subject | Re: [RFC] net: napi fix | From | David Miller <> |
| |
From: Andrew Gallatin <gallatin@myri.com> Date: Thu, 13 Dec 2007 09:13:54 -0500
> If the netif_running() check is indeed required to make a device break > out of napi polling and respond to an ifconfig down, then I think the > netif_running() check should be moved up into net_rx_action() to avoid > potential for driver complexity and bugs like the ones you found.
That, or something like it, definitely sounds reasonable and much better than putting the check into every driver :-)
| |