lkml.org 
[lkml]   [2007]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 33/42] MM: extern for drop_pagecache_sb
In message <20071210140426.GL20441@stusta.de>, Adrian Bunk writes:
> On Sun, Dec 09, 2007 at 09:42:06PM -0500, Erez Zadok wrote:
> > Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
> > ---
> > include/linux/mm.h | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/mm.h b/include/linux/mm.h
> > index 1b7b95c..fc61bd3 100644
> > --- a/include/linux/mm.h
> > +++ b/include/linux/mm.h
> >...
> > @@ -1135,6 +1136,7 @@ int drop_caches_sysctl_handler(struct ctl_table *, int, struct file *,
> > void __user *, size_t *, loff_t *);
> > unsigned long shrink_slab(unsigned long scanned, gfp_t gfp_mask,
> > unsigned long lru_pages);
> > +extern void drop_pagecache_sb(struct super_block *);
> > void drop_pagecache(void);
> > void drop_slab(void);
>
> This breaks compilation (and therefore bisecting) until the function
> becomes non-static in patch #36.
>
> Please merge patches #33 and #36 into one patch.
>
> That's not terribly important now that you've sent the patches for
> review, but keep in mind that the tree should compile at all stages for
> making bisecting possible when preparing the final submission.
>
> cu
> Adrian

Adrian, having used git-bisect successfully before, I agree with you. I've
reorganized my patches now, and merged a few small ones, so they all build
incrementally.

Cheers,
Erez.


\
 
 \ /
  Last update: 2007-12-13 16:09    [W:0.080 / U:3.116 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site