Messages in this thread | | | Date | Thu, 13 Dec 2007 08:53:32 +0100 | From | Pierre Ossman <> | Subject | Re: [PATCH][MMC] Fix wrong EXT_CSD_REV handling |
| |
On Thu, 13 Dec 2007 16:13:11 +0900 Kyungmin Park <kyungmin.park@samsung.com> wrote:
> It already checked the ext_csd_struct is less than 2, > so it doesn't need to check it. > Current code only accepts the revision 1.2. > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
It wasn't wrong the last time you brought this up, and it still isn't wrong. Those bits aren't defined until version 1.2 of the EXT_CSD register, hence we do not trust them. If you have some broken card that you feel you must have support for, then start working on some quirks system.
Rgds -- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
| |