Messages in this thread | | | Subject | Re: [PATCH] x86: Remove 'e' from kprope structure members | From | Harvey Harrison <> | Date | Wed, 12 Dec 2007 15:08:33 -0800 |
| |
On Wed, 2007-12-12 at 15:00 -0800, Jeremy Fitzhardinge wrote: > Harvey Harrison wrote: > > Some kprobe structure members had a superfluous e in their > > name. > > > > eflags -> flags > > esp -> sp > > > > eflags and esp are the actual machine register names (at least in > 32-bit), and therefore more distinctive than just "flags". > > If this is in preparation for a unification then OK, but I disagree if > not (and technically 64-bit should be using rsp/rflags). > > J
My plan was to move forward with unifying these files. If this is still acceptable I will add a comment block documenting this. This doesn't affect anywhere outside of kprobes.h kprobes_32/64.c so if it is clean to unify them, I'll leave them as sp with comment.
Harvey
| |