Messages in this thread | | | Subject | Re: [PATCH 1/1] fix 2.6.24-rc1 nfs_file_mmap change for NOMMU | From | Trond Myklebust <> | Date | Wed, 12 Dec 2007 15:03:24 -0500 |
| |
On Wed, 2007-12-12 at 08:29 +0100, Berkhan, Enrik (GE Infra, Oil & Gas) wrote: > Trond Myklebust wrote: > > On Sun, 2007-12-09 at 19:52 +0100, Berkhan, Enrik (GE Infra, Oil & Gas) > > wrote: > >> - generic_file_mmap returns -ENOSYS for NOMMU systems; replicate this > >> behaviour > > > > Why do that after going through the process of revalidating the inode > > etc.? Just replace nfs_file_mmap() with a function returning ENOSYS in > > the case of CONFIG_MMU. > > > > Better still, in the case of CONFIG_MMU, instead of having an > > nfs_file_mmap(), just replace the .mmap field in nfs_file_operations > > with a call to generic_file_mmap(). > > I just tried to make it work without really knowing what I do :) > > I have mailed another patch implementing your second suggestion (the system > still boots with nfsroot).
Thanks. That patch looks better. I have 2 questions, though:
1. Is this urgent enough to warrant pushing into 2.6.24? 2. Are there any filesystems which support mmap() on !CONFIG_MMU?
Cheers Trond
| |