Messages in this thread | | | Date | Wed, 12 Dec 2007 13:14:58 -0600 | From | Anthony Liguori <> | Subject | Re: [PATCH] xen: relax signature check |
| |
Jeremy Fitzhardinge wrote: > Bodo Eggert wrote: >> Not BUG_ON(memcmp(xen_start_info->magic, "xen-3.", 6) != 0); ? >> I don't thin Xen version 32 will be compatible ... >> > > It had better be; if it loads the kernel, it should present a xen-3 > compatible ABI.
If xen-32.0 should be compatible than wouldn't xen-24.0 be compatible too? I think the point was that you should either be checking for 'xen-3.x' or something more general that would accept anything >= xen-3.0.
Regards,
Anthony Liguori
> But this is just a sanity check to make sure things are basically OK; > BUG_ON is hardly nice error reporting (not that there's much else we can > do at that point). > > J
| |