Messages in this thread | | | Date | Tue, 11 Dec 2007 22:55:24 -0800 | From | Greg KH <> | Subject | Re: [PATCH -mm] x86 boot : export boot_params via sysfs |
| |
On Wed, Dec 12, 2007 at 12:42:48PM +0800, Dave Young wrote: > On Dec 12, 2007 10:40 AM, Andrew Morton <akpm@linux-foundation.org> wrote: > > On Tue, 11 Dec 2007 16:49:09 +0000 "Huang, Ying" <ying.huang@intel.com> wrote: > > > > > This patch export the boot parameters via sysfs. This can be used for > > > debugging and kexec. > > > > > > The files added are as follow: > > > > > > /sys/kernel/boot_params/data : binary file for struct boot_params > > > /sys/kernel/boot_params/version : boot protocol version > > > > Your patch uses kobject_create_and_register() which was added in Greg's > > driver tree as of 2.6.24-rc4-mm1. > > > > However for some reason kobject_create_and_register() has magically vanished > > from Greg's current driver tree so I cannot carry this patch, sorry. > > Seems kobject_create_and_register would be replaced by > kobject_create_and_add, and the uevent handling would be separated > from original create_and_register onefunction.
Yes, that is what has now changed.
> wait for greg's patches or modify to use: > > kobject_init > kobject_add > kobject_uevent > > BTW, I suspect whether the uevent is really needed for boot_params object.
Actually, for something as trivial as this, just use the kobject_create_and_add() and don't worry about the uevent. It should be pretty trivial.
thanks,
greg k-h
| |