Messages in this thread | | | Date | Wed, 12 Dec 2007 15:05:26 +0900 | From | "Joonwoo Park" <> | Subject | Re: [RFC] net: napi fix |
| |
2007/12/12, Stephen Hemminger <shemminger@linux-foundation.org>: > Isn't this a better fix for all drivers, rather than peppering every > driver with the special case. This is how the logic worked up until > 2.6.24. > > > --- a/net/core/dev.c 2007-12-11 12:16:20.000000000 -0800 > +++ b/net/core/dev.c 2007-12-11 21:43:39.000000000 -0800 > @@ -2184,7 +2184,7 @@ static void net_rx_action(struct softirq > > have = netpoll_poll_lock(n); > > - weight = n->weight; > + weight = min(n->weight, budget); > > /* This NAPI_STATE_SCHED test is for avoiding a race > * with netpoll's poll_napi(). Only the entity which >
Stephen, Could you explain how it fix the problem? IMHO I think your patch cannot solve the problem. The drivers can call netif_rx_complete and net_rx_action can do list_move_tail also. Am I missing something?
Thanks Joonwoo
| |