Messages in this thread | | | Date | Wed, 12 Dec 2007 07:12:54 -0800 (PST) | Subject | Re: [PATCH] [NET]: Fix Ooops of napi net_rx_action. | From | David Miller <> |
| |
From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com> Date: Tue, 11 Dec 2007 16:38:37 -0800
> @@ -3933,6 +3933,10 @@ quit_polling: > e1000_set_itr(adapter); > netif_rx_complete(poll_dev, napi); > e1000_irq_enable(adapter); > + if (work_done == weight) > + return work_done - 1; > + else > + return work_done;
Don't do this.
If you processed "weight" worth of packets, return that exact value and do not netif_rx_complete() and do not re-enable interrupts.
That is the only correct fix.
| |