lkml.org 
[lkml]   [2007]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/6] USB: net2280 can't have a function called show_registers() [try #5]
    Date
    net2280 can't have a function called show_registers() because this can produce
    a namespace clash with an arch function of the same name.

    All this driver's functions and variables should really be prefixed with
    "net2280_" to avoid such a problem in future.

    Signed-off-by: David Howells <dhowells@redhat.com>
    ---

    drivers/usb/gadget/net2280.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c
    index d5d473f..9e14d98 100644
    --- a/drivers/usb/gadget/net2280.c
    +++ b/drivers/usb/gadget/net2280.c
    @@ -1419,7 +1419,7 @@ show_function (struct device *_dev, struct device_attribute *attr, char *buf)
    static DEVICE_ATTR (function, S_IRUGO, show_function, NULL);

    static ssize_t
    -show_registers (struct device *_dev, struct device_attribute *attr, char *buf)
    +net2280_show_registers (struct device *_dev, struct device_attribute *attr, char *buf)
    {
    struct net2280 *dev;
    char *next;
    @@ -1571,7 +1571,7 @@ show_registers (struct device *_dev, struct device_attribute *attr, char *buf)

    return PAGE_SIZE - size;
    }
    -static DEVICE_ATTR (registers, S_IRUGO, show_registers, NULL);
    +static DEVICE_ATTR (registers, S_IRUGO, net2280_show_registers, NULL);

    static ssize_t
    show_queues (struct device *_dev, struct device_attribute *attr, char *buf)
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-09 16:39    [W:0.025 / U:2.676 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site