lkml.org 
[lkml]   [2007]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC 3/7] x86: clean up asm-x86/page*.h
Glauber de Oliveira Costa wrote:
> On Nov 7, 2007 11:50 PM, Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>> +#define PAGETABLE_LEVELS 3
>> +
>> +typedef u64 pteval_t;
>> +typedef u64 pmdval_t;
>> +typedef u64 pudval_t;
>> +typedef u64 pgdval_t;
>> +
>>
>
>
>> -static inline unsigned long long native_pgd_val(pgd_t pgd)
>> +static inline pgdval_t native_pgd_val(pgd_t pgd)
>> {
>>
> Maybe these kind of things, the typedef and native_xxx definitions can
> go into the common header, after we define the PAGETABLE_LEVELS
> constant?
> I think the more goes into common headers, the better.
>

You mean put them in a common header, but conditionally by #if
PAGETABLE_LEVELS? I don't think that would be much of an improvement;
it would just add more #ifs, which adds lines and conceptual
complexity. If you go that way, you may as well put everything in one
header wrapped in #ifs, but personally I don't think that would help.

J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-08 22:03    [from the cache]
©2003-2011 Jasper Spaans