lkml.org 
[lkml]   [2007]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 04/23] dentries: Extract common code to remove dentry from lru
Hi Christoph,

On Tue, Nov 06, 2007 at 05:11:34PM -0800, Christoph Lameter wrote:
> @@ -613,11 +606,7 @@ static void shrink_dcache_for_umount_sub
> spin_lock(&dcache_lock);
> list_for_each_entry(loop, &dentry->d_subdirs,
> d_u.d_child) {
> - if (!list_empty(&loop->d_lru)) {
> - dentry_stat.nr_unused--;
> - list_del_init(&loop->d_lru);
> - }
> -
> + dentry_lru_remove(dentry);

Shouldn't this be dentry_lru_remove(loop)?

Hannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-07 09:55    [W:2.418 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site