Messages in this thread | | | Date | Wed, 7 Nov 2007 12:39:22 -0800 | From | Stephane Eranian <> | Subject | Re: [PATCH] fix up perfmon to build on -mm |
| |
Greg,
On Wed, Nov 07, 2007 at 11:53:20AM -0800, Greg KH wrote: > > > > > > Do you want me to send you patches based on this tree to help clean up > > > the sysfs usage now that it's documented? > > > > > Yes, send me the patches. But from what you were saying earlier it seems > > I would need an extra sysfs patches to make this compile. Is that particular > > patch already in Linus's tree? > > No, it's in my tree, and will be in the next -mm. You will need a few > patches to get this to work, not just a single patch. > Could you send them to me? if they are not too intrusive I could add them to my tree. Yet I don't want something to distant from Linus's tree which I pull from. My goal is to ensure that my tree still compiles and works.
> > > Also, a lot of your per-cpu sysfs files should probably move to debugfs > > > as they are for debugging only, right? No need to clutter up sysfs with > > > them when only the very few perfmon developers would be needing access > > > to them. > > > > > Yes, this is mostly debugging. If debugfs is meant for this, then I'll > > be happy to move this stuff over there. Is there some good example of how > > I could do that based on my current sysfs code? > > There is documentation for debugfs in the kernel api document :) > > And, there are many in-kernel users of debugfs, a grep for > "debugfs_create_" should show you some examples of how to use this. If > you have any questions, please let me know. > Ok, I'll look at that next.
Thanks,
--
-Stephane - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |