Messages in this thread | | | Date | Wed, 7 Nov 2007 09:07:34 -0800 | From | Greg KH <> | Subject | Re: [PATCH] fix up perfmon to build on -mm |
| |
On Wed, Nov 07, 2007 at 02:34:49AM -0800, Stephane Eranian wrote: > Greg, > > On Tue, Nov 06, 2007 at 04:34:54PM -0800, Greg KH wrote: > > Here's a patch against my current tree that gets the perfmon code > > building and hopefully working. > > > Thanks for your quick help. > > > Note, it needs the kobject_create_and_register() patch which is in my > > tree, but I do not think it made it to -mm yet. The next -mm cycle > > should have it. > > > > Also, the sysfs usage in the perfmon code is quite strange and not > > documented at all. Yes, there is a little bit in the documentation > > about what a few of the files do, but there are _way_ more files and > > even directories being created under /sys/kernel/perfmon/ that are not > > documented at all here. > > > The full documentation for /sys/kernel/perfmon is in Documentation/perfmon2.txt
That is what I was referring to, that file does not describe all of the sysfs files in /sys/kernel/perfmon by far.
> > If you document this stuff, I think I can clean up your sysfs code a > > lot, making things simpler, easier to extend, and easier to understand. > > But as it is, I don't want to break anything as it's totally unknown how > > this stuff is supposed to work... > > > I certainly welcome your help. > > > Hint, use the Documentation/ABI directory to document your sysfs > > interfaces, that is what it is there for... > > > I will move the description from perfmon2.txt to its own file in > ABI/testing.
That would be great to have, thanks.
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |