lkml.org 
[lkml]   [2007]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: device struct bloat
From
Date
On Mon, 2007-11-05 at 14:49 -0800, Greg KH wrote:
> On Mon, Nov 05, 2007 at 11:57:14AM +0100, Peter Zijlstra wrote:
> > Hmm, the problem seems to be stuff like:
> >
> > add usb driver to pci
> > scan pci devices
> > add usb host controller device
> > scan usb devices
> > add usb hub device
> > scan usb devices
> > add usb .....
> >
> > This seems to be able to go on forever, as long as one can cascade usb
> > hubs.
>
> USB hubs only work 7 deep, so there is a limit.

Ah, missed that bit of knowledge :-)

> > Doesn't seem like an ideal thing to do from a stack space POV either.
> >
> > Would it be possible to break at the second scan, that is the device
> > probe and stick that into a workqueue or something. Then we'd only ever
> > have driver->device nesting.
>
> Alan and Oliver have done some work in this area I think, combined with
> the suspend/bind/unbind issues. I'll let them comment on your patch :)

Great, so the thing I need to make this work nicely is a limited
device->mutex nesting, if these changes result in that we can work
together to finish this conversion.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-06 10:51    [W:0.077 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site