Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [2.6 patch] usb/serial/oti6858.c: cleanups | Date | Mon, 5 Nov 2007 21:40:43 +0100 |
| |
Am Montag 05 November 2007 schrieb Adrian Bunk: > This patch containsthe following cleanups: > - make the needlessly global send_data() static > - an author without anemail address is OK, not a FIXME
That should be up to the author. If he thinks it should be there it might be worth a FIXME
> - directly put the IDs into the id_table
Why?
> - remove the now-empty oti6858.h > - kill the pointless driver version number
Why? There might be a new version in the future. If the author put it there he might have had his reasons.
Regards Oliver
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |