Messages in this thread | | | Date | Fri, 30 Nov 2007 19:23:15 +0300 | From | Pavel Emelyanov <> | Subject | Re: [PATCH 4/4] net: Implement the per network namespace sysctl infrastructure |
| |
[snip]
>> + &namespaces, path, table); > > Hey Eric, > > the patches look nice.
Agree ;)
> The hand-forcing of the passed-in net_ns into a copy of current->nsproxy > does make it seem like nsproxy may not be the best choice of what to > pass in. Doesn't only net_sysctl_root->lookup() look at the argument? > > But I assume you don't want to be more general than sending in a > nsproxy so as to dissuade abuse of this interface for needlessly complex > sysctl interfaces? > > (Well I expect that'll become clear once the the patches using this > come out.) > > Are you planning to use this infrastructure for the uts and ipc > sysctls as well?
I have sent some patches concerning uts and ipc already. I'd appreciate any feedback on it :)
> thanks, > -serge
Thanks, Pavel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |