Messages in this thread | | | Date | Fri, 30 Nov 2007 07:04:10 -0600 | From | Bill Gatliff <> | Subject | Re: [patch/rfc 2/4] pcf875x I2C GPIO expander driver |
| |
Jean Delvare wrote: > !!(value & (1 << offset)) > is more efficiently written > (value >> offset) & 1 >
... but not more efficiently implemented.
Your version requires code to do the shift on live data at runtime. David's version lets the compiler create the mask once, at compile-time.
b.g.
-- Bill Gatliff bgat@billgatliff.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |