[lkml]   [2007]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch/rfc 2/4] pcf875x I2C GPIO expander driver
Jean Delvare wrote:
> !!(value & (1 << offset))
> is more efficiently written
> (value >> offset) & 1

... but not more efficiently implemented.

Your version requires code to do the shift on live data at runtime.
David's version lets the compiler create the mask once, at compile-time.


Bill Gatliff

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2007-11-30 14:31    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean