Messages in this thread Patch in this message | | | From | Roland McGrath <> | Subject | Re: [PATCH x86/mm 05/11] x86 ptrace getreg/putreg merge | Date | Thu, 29 Nov 2007 14:28:42 -0800 (PST) |
| |
> This didn't need to be implemented as a macro hence it shouldn't have been.
Ok.
diff --git a/arch/x86/kernel/ptrace.c b/arch/x86/kernel/ptrace.c index b3433e1..0000000 100644 --- a/arch/x86/kernel/ptrace.c +++ b/arch/x86/kernel/ptrace.c @@ -45,8 +45,10 @@ /* * Determines whether a value may be installed in a segment register. */ -#define invalid_selector(value) \ - ((value) != 0 && ((value) & SEGMENT_RPL_MASK) != USER_RPL) +static inline bool invalid_selector(u16 value) +{ + return unlikely(value != 0 && (value & SEGMENT_RPL_MASK) != USER_RPL); +} #ifdef CONFIG_X86_32 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |