Messages in this thread Patch in this message | | | Date | Wed, 28 Nov 2007 18:55:10 +0000 (GMT) | From | Hugh Dickins <> | Subject | [PATCH] tmpfs: restore missing clear_highpage |
| |
tmpfs was misconverted to __GFP_ZERO in 2.6.11. There's an unusual case in which shmem_getpage receives the page from its caller instead of allocating. We must cover this case by clear_highpage before SetPageUptodate, as before.
Signed-off-by: Hugh Dickins <hugh@veritas.com> --- Desirable in 2.6.23-stable and 2.6.22-stable and 2.6.16-stable (and any other 2.6-stable if not already at end of life).
mm/shmem.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
--- 2.6.24-rc3-git/mm/shmem.c 2007-10-31 06:18:05.000000000 +0000 +++ linux/mm/shmem.c 2007-11-28 17:01:20.000000000 +0000 @@ -1072,7 +1072,7 @@ shmem_alloc_page(gfp_t gfp, struct shmem pvma.vm_policy = mpol_shared_policy_lookup(&info->policy, idx); pvma.vm_pgoff = idx; pvma.vm_end = PAGE_SIZE; - page = alloc_page_vma(gfp | __GFP_ZERO, &pvma, 0); + page = alloc_page_vma(gfp, &pvma, 0); mpol_free(pvma.vm_policy); return page; } @@ -1093,7 +1093,7 @@ shmem_swapin(struct shmem_inode_info *in static inline struct page * shmem_alloc_page(gfp_t gfp,struct shmem_inode_info *info, unsigned long idx) { - return alloc_page(gfp | __GFP_ZERO); + return alloc_page(gfp); } #endif @@ -1306,6 +1306,7 @@ repeat: info->alloced++; spin_unlock(&info->lock); + clear_highpage(filepage); flush_dcache_page(filepage); SetPageUptodate(filepage); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |