lkml.org 
[lkml]   [2007]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead
    On Tue, 27 Nov 2007 13:03:29 +0800 "rae l" <crquan@gmail.com> wrote:

    > -static void hexdump(unsigned char *buf, unsigned int len)
    > +static inline void hexdump(unsigned char *buf, unsigned int len)
    > {
    > - while (len--)
    > - printk("%02x", *buf++);
    > -
    > - printk("\n");
    > + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET,
    > + 16, 1,
    > + buf, len, false);
    > }

    uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes
    down to 19,701.

    inlining is almost always wrong.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-27 10:31    [W:0.020 / U:0.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site