lkml.org 
[lkml]   [2007]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 11/14] Powerpc: Use generic per cpu
Christoph Lameter writes:

> On Wed, 28 Nov 2007, Paul Mackerras wrote:
>
> > Did you try both 32-bit (CONFIG_64BIT=n) and 64-bit (CONFIG_64BIT=y)
> > configurations? The paca only exists in 64-bit kernels.
>
> I build both and there is no dependency on 32bit or 64 bit in
> include/asm-powerpc/percpu.h. Both access the paca (whatever that is).

Look at line 3 of include/asm-powerpc/percpu.h:

#ifdef __powerpc64__

As far as I can see, after applying your series of patches, I end up
with an unbalanced #ifdef in include/asm-powerpc/percpu.h. I see 3
#ifdef/#ifndef, but only two #endifs. It needs another #endif after
the #endif /* SMP */ to match the #ifdef __powerpc64__. With that
change it looks OK, since 32-bit uses asm-generic/percpu.h for both
SMP and UP.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-28 03:39    [W:0.784 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site