Messages in this thread | | | Date | Tue, 27 Nov 2007 14:38:59 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN |
| |
On Tue, Nov 27, 2007 at 02:32:49PM +0900, Joonwoo Park wrote: > > Thanks Herbert. > Well.. I think patch would work propely for AF_PACKET also. > (I did not insert BUG() macro in my patch) > How do you think?
Are you sure? I thought you need to check both in the xmit function. That is,
if (veth->h_vlan_proto != htons(ETH_P_8021Q) || VLAN_DEV_INFO(dev)->flags & VLAN_FLAG_REORDER_HDR) {
Otherwise you'll miss AF_PACKET packets when REORDER is off.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |