Messages in this thread | | | Date | Tue, 27 Nov 2007 11:43:14 -0800 | From | Chris Wedgwood <> | Subject | Re: [PATCH] xfs: revert to double-buffering readdir |
| |
On Sun, Nov 25, 2007 at 04:30:14PM +0000, Christoph Hellwig wrote:
> The current readdir implementation deadlocks on a btree buffers > locks because nfsd calls back into ->lookup from the filldir > callback. The only short-term fix for this is to revert to the old > inefficient double-buffering scheme.
This seems to work really well here.
> This patch does exactly that and reverts xfs_file_readdir to what's > basically the 2.6.23 version minus the uio and vnops junk.
This should probably be submitted for inclusion stable-2.6.24. Perhaps a version with the #if 0 [...] stuff dropped? (I'm happy to send a patch for that if you prefer). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |