lkml.org 
[lkml]   [2007]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] Add iSCSI IBFT Support (v0.3)
    On Mon, Nov 26, 2007 at 09:29:55PM -0800, Greg KH wrote:
    > On Mon, Nov 26, 2007 at 11:23:31PM -0500, Konrad Rzeszutek wrote:
    > > On Monday 26 November 2007 22:31:38 Greg KH wrote:
    > > > > +#if defined(CONFIG_ISCSI_IBFT) || defined(CONFIG_ISCSI_IBFT_MODULE)
    > > ..snip..
    > > > > +static ssize_t find_ibft(void)
    > > > > +{
    > > ..snip..
    > > > > +}
    > > >
    > > > What is a function (not even an inline one) doing in a .h file?
    > >
    > > I was not sure where to put it. This function (find_ibft) is used by the
    > > setup_[32|64].c and the iscsi_ibft.c code. Randy suggested I put in .c file,
    > > but I am not sure exactly where? Should I make a new file in called
    > > libs/iscsi_ibft_helper.c ?
    >
    > Put it in your .c file and make it a global function to be called by
    > someone else if they need it.

    If the kernel is built with CONFIG_ISCSI_IBFT=m, the
    setup_[32|64],c code would depend on the 'find_ibft' symbol which is
    in a module (in the iscsi_ibft.c), which is not available during
    the bootup phase and not linked to vmlinuz.

    This isn't an issue if the module is built with CONFIG_ISCSI_IBFT=y of
    course.

    Or did by 'your .c file' mean a new file in arch/x86/kernel directory?
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-27 19:15    [W:0.027 / U:0.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site