lkml.org 
[lkml]   [2007]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/6] Suspend: Use common prefix in messages
    Date
    On Tuesday, 27 of November 2007, Pavel Machek wrote:
    > Hi!
    >
    > > From: Rafael J. Wysocki <rjw@sisk.pl>
    > >
    > > Make suspend messages start with one common prefix "PM: ".
    > >
    > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
    >
    > I do not think I like the PREFIX idea (see other message).

    The problem is that we use three different types of messages:
    - with no prefix at all
    - with "PM: "
    - with "swsusp: "
    and I think that we should use just one, preferably "PM: ".

    > > @@ -344,11 +344,12 @@ static int enter_state(suspend_state_t s
    > > if (!mutex_trylock(&pm_mutex))
    > > return -EBUSY;
    > >
    > > - printk("Syncing filesystems ... ");
    > > + printk(KERN_INFO PREFIX "Syncing filesystems ... ");
    > > sys_sync();
    > > - printk("done.\n");
    > > + printk(KERN_INFO "done.\n");
    >
    >
    > Plus this is wrong.

    Yes, I've had a temporary blackout regarding prinkt(), not even making much
    sense ...

    I'll resend the entire series in a while.

    Greetings,
    Rafael
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-27 17:01    [W:0.024 / U:0.872 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site