lkml.org 
[lkml]   [2007]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()
    >  	ret = sparse_init_one_section(ms, section_nr, memmap, usemap);
    > @@ -414,7 +418,7 @@ int sparse_add_one_section(struct zone *
    > out:
    > pgdat_resize_unlock(pgdat, &flags);
    > if (ret <= 0)
    > - __kfree_section_memmap(memmap, nr_pages);
    > + kfree(usemap);
    > return ret;
    > }
    > #endif
    >

    I guess you think __kfree_section_memmap() is not necessary due to
    no implementation. But, it is still available when
    CONFIG_SPARSEMEM_VMEMMAP is off. So, it should not be removed.


    Bye.

    --
    Yasunori Goto


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-27 13:07    [W:0.032 / U:30.840 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site