lkml.org 
[lkml]   [2007]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] Add iSCSI IBFT Support (v0.3)
    Date
    > >
    > > sysfs files have ONE VALUE PER FILE, not a whole bunch of different
    > > things in a single file. Please fix this.
    >
    > The subparameters _are_ actually part of a single value, that value being
    > associated with the initiator instance.
    >
    > Konrad is trying to implement a "work-alike" for what open firmware does.
    > open-iscsi already has the ability to extract the same format
    > bits from real OFW.
    >
    > See open-iscsi.git/utils/fwparam_ppc.


    Greg,

    In light of what Doug says (which is all true), should I go ahead with a new
    version of this module which would export one value per file? The problem
    that will be encountered is that a ethernetX sysfs directory would have (for
    example):

    /sys/firmware/ibft/ethernet0/pci-bdf
    5:1:0
    /sys/firmware/ibft/ethernet0/mac
    00:11:25:9d:8b:00
    /sys/firmware/ibft/ethernet0/vlan
    0
    /sys/firmware/ibft/ethernet0/gateway
    192.168.79.254
    /sys/firmware/ibft/ethernet0/origin
    0
    /sys/firmware/ibft/ethernet0/subnet-mask
    22
    /sys/firmware/ibft/ethernet0/ip-addr
    192.168.77.41
    /sys/firmware/ibft/ethernet0/flags
    7

    And the flag would contain the value "7" which would mean the user would have
    to parse what each bit means? (the v0.3 of the module does not export this
    flag but uses it to figure out which is the boot iSCSI target).

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-27 05:59    [W:0.037 / U:30.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site