lkml.org 
[lkml]   [2007]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/6] Hibernation: Move extern definition to header file
    Hi!

    > From: Rafael J. Wysocki <rjw@sisk.pl>
    >
    > Move the extern definition of resume_file[] from kernel/power/swap.c
    > to kernel/power/power.h .
    >
    > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

    can we just get rid of extern? It does not seem to be used. (at least
    in very quick grep over 2.6.24-rc3):

    pavel@amd:/data/l/linux/kernel/power$ grep resume_file *.c
    disk.c:char resume_file[256] = CONFIG_PM_STD_PARTITION;
    disk.c: if (!strlen(resume_file)) {
    disk.c: swsusp_resume_device = name_to_dev_t(resume_file);
    disk.c: pr_debug("swsusp: Resume From Partition %s\n",
    resume_file);
    disk.c: strncpy( resume_file, str, 255 );
    swap.c:extern char resume_file[];
    pavel@amd:/data/l/linux/kernel/power$

    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-27 01:25    [W:0.022 / U:31.240 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site