lkml.org 
[lkml]   [2007]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: unionfs: several more problems
    In message <Pine.LNX.4.64.0711201802480.9934@blonde.wat.veritas.com>, Hugh Dickins writes:

    [...]
    > Please try running LTP (e.g. ltp-full-20071031.tgz) after something like
    [...]

    Hugh,

    I just posted a series of patches to unionfs (already in unionfs.git on
    korg), which fix every problem LTP found, as well as other problems
    mentioned in your email. With this series of patches, the same set of tests
    which pass on ext3 also pass with unionfs mounted over ext3.

    I'd like to call your attention to one small unionfs_writepage fix. One of
    the ltp fs tests (rwtest04) triggered a BUG_ON(PageWriteback(page)) in
    fs/buffer.c:1706, when we call the lower ->writepage. This was due to
    multiple writers to the same page. Looking at other kernel code, it seems
    that the right fix is to use wait_on_page_writeback(lower_page) to serialize
    concurrent writebacks to the same page, no? The small patch below fixed the
    problem. Let me know what you think.

    Thanks,
    Erez.


    diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c
    index eef43aa..d0fd4d0 100644
    --- a/fs/unionfs/mmap.c
    +++ b/fs/unionfs/mmap.c
    @@ -73,6 +73,7 @@ static int unionfs_writepage(struct page *page, struct writeback_control *wbc)

    BUG_ON(!lower_mapping->a_ops->writepage);
    clear_page_dirty_for_io(lower_page); /* emulate VFS behavior */
    + wait_on_page_writeback(lower_page); /* prevent multiple writers */
    err = lower_mapping->a_ops->writepage(lower_page, wbc);
    if (err < 0)
    goto out_release;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-11-26 17:57    [W:0.023 / U:119.700 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site