lkml.org 
[lkml]   [2007]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC] Documentation about unaligned memory access
    From
    Date

    > Going back to an earlier example:
    > void myfunc(u8 *data, u32 value)
    > {
    > [...]
    > *((u16 *) data) = cpu_to_le32(value);
    > [...]

    typo? should it be a u32 cast?

    > To avoid the unaligned memory access, you could rewrite it as follows:
    >
    > void myfunc(u8 *data, u32 value)
    > {
    > [...]
    > value = cpu_to_le32(value);
    > memcpy(data, value, sizeof(value));
    > [...]
    > }

    I think you should use put_unaligned here as well. Or maybe just reorder
    this vs. the section below where you use get/put_unaligned.

    johannes
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2007-11-26 16:51    [W:0.043 / U:30.352 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site