Messages in this thread | | | Date | Sat, 24 Nov 2007 15:15:18 +0800 | From | "Bryan Wu" <> | Subject | Re: [PATCH 1/1] [MTD/NAND]: Add Blackfin BF52x on-chip NAND Flash controller driver support in bf5xx_nand driver |
| |
On Nov 24, 2007 2:43 PM, David Woodhouse <dwmw2@infradead.org> wrote: > > On Fri, 2007-11-23 at 17:04 -0500, Robin Getz wrote: > > It could be a runtime if() but we don't currently have the is_mach() all set > > up properly today. > > > > This is because on most systems that Blackfin ships on - memory is the > > dominate cost of the system, and end users don't want to take the either the > > storage (flash) hit of having code they don't use, or the run time (DRAM) > > overhead. They are fine with compiling 2 kernels for two platforms if it > > means things are cheaper. :) > > > > That being said, we still need to go back, and add things properly - and just > > let gcc optimise things away if it is not used - c code is more maintainable > > than all the ifdefs we have today. > > > > This is the goal - it will just take a little bit to get there. > > For now I suspect you could at least define machine_is_bf52x() and > machine_is_bf54x() which are hard-coded to either zero or one according > to the configuration, and at least you wouldn't need to add ifdefs to > drivers. >
We got some plan to do this, but maybe cpu_is_bf52x() and cpu_is_bf54x() are better. Thanks.
-Bryan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |