lkml.org 
[lkml]   [2007]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/7] Blackfin RTC driver: cleanup proc handler (we dont need RTC reg dump now that we have MMR filesystem in sysfs)
    Date
    From: Mike Frysinger <michael.frysinger@analog.com>

    Signed-off-by: Mike Frysinger <michael.frysinger@analog.com>
    Signed-off-by: Bryan Wu <bryan.wu@analog.com>
    ---
    drivers/rtc/rtc-bfin.c | 26 ++++++++++++--------------
    1 files changed, 12 insertions(+), 14 deletions(-)

    diff --git a/drivers/rtc/rtc-bfin.c b/drivers/rtc/rtc-bfin.c
    index 2a801f2..343f284 100644
    --- a/drivers/rtc/rtc-bfin.c
    +++ b/drivers/rtc/rtc-bfin.c
    @@ -45,7 +45,7 @@

    #include <asm/blackfin.h>

    -#define stamp(fmt, args...) pr_debug("%s:%i: " fmt "\n", __FUNCTION__, __LINE__, ## args)
    +#define stamp(fmt, args...) pr_debug("%s:%i: " fmt "\n", __func__, __LINE__, ## args)
    #define stampit() stamp("here i am")

    struct bfin_rtc {
    @@ -343,22 +343,20 @@ static int bfin_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)

    static int bfin_rtc_proc(struct device *dev, struct seq_file *seq)
    {
    -#define yesno(x) (x ? "yes" : "no")
    +#define yesno(x) ((x) ? "yes" : "no")
    u16 ictl = bfin_read_RTC_ICTL();
    stampit();
    - seq_printf(seq, "alarm_IRQ\t: %s\n", yesno(ictl & RTC_ISTAT_ALARM));
    - seq_printf(seq, "wkalarm_IRQ\t: %s\n", yesno(ictl & RTC_ISTAT_ALARM_DAY));
    - seq_printf(seq, "seconds_IRQ\t: %s\n", yesno(ictl & RTC_ISTAT_SEC));
    - seq_printf(seq, "periodic_IRQ\t: %s\n", yesno(ictl & RTC_ISTAT_STOPWATCH));
    -#ifdef DEBUG
    - seq_printf(seq, "RTC_STAT\t: 0x%08X\n", bfin_read_RTC_STAT());
    - seq_printf(seq, "RTC_ICTL\t: 0x%04X\n", bfin_read_RTC_ICTL());
    - seq_printf(seq, "RTC_ISTAT\t: 0x%04X\n", bfin_read_RTC_ISTAT());
    - seq_printf(seq, "RTC_SWCNT\t: 0x%04X\n", bfin_read_RTC_SWCNT());
    - seq_printf(seq, "RTC_ALARM\t: 0x%08X\n", bfin_read_RTC_ALARM());
    - seq_printf(seq, "RTC_PREN\t: 0x%04X\n", bfin_read_RTC_PREN());
    -#endif
    + seq_printf(seq,
    + "alarm_IRQ\t: %s\n"
    + "wkalarm_IRQ\t: %s\n"
    + "seconds_IRQ\t: %s\n"
    + "periodic_IRQ\t: %s\n",
    + yesno(ictl & RTC_ISTAT_ALARM),
    + yesno(ictl & RTC_ISTAT_ALARM_DAY),
    + yesno(ictl & RTC_ISTAT_SEC),
    + yesno(ictl & RTC_ISTAT_STOPWATCH));
    return 0;
    +#undef yesno
    }

    /**
    --
    1.5.3.4
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2007-11-23 11:13    [W:2.453 / U:0.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site