Messages in this thread | | | Date | Fri, 23 Nov 2007 18:02:39 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH 9/9] Clean up open coded inode dirty checks |
| |
> +STATIC_INLINE int xfs_inode_clean(xfs_inode_t *ip) > +{ > + return (((ip->i_itemp == NULL) || > + !(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) && > + (ip->i_update_core == 0)); > +}
Can we please get rid of this useless STATIC_INLINE junk? It's really hurting my eyes. As does to a lesser extent the verbose style of this function. This should be something like:
static inline int xfs_inode_clean(struct xfs_inode *ip) { return (!ip->i_itemp || !(ip->i_itemp->ili_format.ilf_fields & XFS_ILOG_ALL)) && !ip->i_update_core; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |