Messages in this thread | | | Date | Fri, 23 Nov 2007 07:23:54 +0300 | From | "Cyrill Gorcunov" <> | Subject | Re: [PATCH] PPC: CHRP - fix possible NULL pointer dereference |
| |
On 11/23/07, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > On Thu, 22 Nov 2007 22:54:23 +0300 Cyrill Gorcunov <gorcunov@gmail.com> > wrote: > > > > This patch does fix possible NULL pointer dereference > > inside of strncmp() if of_get_property() failed. > > Thanks for this. > > > static void __init sio_init(void) > > { > > struct device_node *root; > > + const char *model = NULL; > > You don't need this initialization as you always assign the variable > before you use it. > > > + root = of_find_node_by_path("/"); > > + if (root) { > > if (!root) > return; > > would save a level of indentation. Not important. > > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au > http://www.canb.auug.org.au/~sfr/ > Oh my :) Thanks. I'll fix it and resend. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |