Messages in this thread | | | Date | Wed, 21 Nov 2007 08:32:46 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH 07/18] x86 vDSO: vdso32 build |
| |
On Tue, Nov 20, 2007 at 11:10:15PM -0800, Roland McGrath wrote: > > > +# This makes sure the $(obj) subdirectory exists even though vdso32/ > > > +# is not a kbuild sub-make subdirectory. > > > +override obj-dirs = $(dir $(obj)) $(obj)/vdso32/ > > > > Should we teach kbuild to create dirs specified in targets? > > Or we could 'fix' it so you do not need the override. > > Something cleaner would be nice, yes. I'll leave it to you to decide.
OK - if I come up with something smart I will convert the vdso stuff.
> > > use "set -e; in front of this shell script to bail out early > > in case of errors. > > Back when I knew something about make, all commands ran with sh -ec. > Ah, progress. Anyway, the one you cited does not have any commands that > aren't tested with && or if already. set -e would have no effect. I assume that if an error happened in a pipe set -e; would catch it. But I did not check that - I normally just adds set -e; without much thought.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |