Messages in this thread | | | Date | Wed, 21 Nov 2007 12:05:41 +0800 | From | "eric miao" <> | Subject | Re: [patch] 0/4 Support for Toshiba TMIO multifunction devices |
| |
On Nov 21, 2007 11:54 AM, ian <spyro@f2s.com> wrote: > On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote: > > Roughly went through the patch, looks good, here comes the remind, though :-) > > > > 1. is it possible to use some name other than "soc_core", maybe > > "tmio_core" so that other multifunction chips sharing a core base > > will live easier. > > It's (soc-core) not tmio MFD specific - its already used by other MFD > chips (although obviously not ones in mainline (yet!) > > it might be better named 'mfd-core' though, as thats its intended use... > > > 2. those C++ style comments "//" are not so pleasant... > > Should I clean them up and resubmit? >
Will be nice then, anyway, could you inline them so others can comment?
> More to the point, who should I be submitting them to? the files under > arm/ are obviously for RMK to peruse, but I couldnt find an entry for > drivers/mfd in MAINTAINERS... >
Well, I briefly went through the git history, looks like Russell is the proper one you could sent them to (probably not) :-)
> >
-- Cheers - eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |