Messages in this thread | | | Date | Tue, 20 Nov 2007 18:59:04 -0600 | From | Robert Hancock <> | Subject | Re: [PATCH 1/2] sata_nv: don't use legacy DMA in ADMA mode |
| |
Tejun Heo wrote: > Tejun Heo wrote: >> If so, can you please add that switching into register mode is okay as >> long as there's no other ADMA commands in flight and add >> WARN_ON((qc->flags & ATA_QCFLAG_RESULT_TF) && link->sactive)? > > More accurately, link->sactive test can be substituted with > (ap->qc_allocated & ~(1 << qc->tag)).
Unfortunately we only get the ata_port and ata_taskfile in the tf_read callback, so I'm not sure if we can do the equivalent of the qc->flags & ATA_QCFLAG_RESULT_TF test (i.e. distinguishing between the error-handling case where we care if we abort outstanding commands and the normal case with a RESULT_TF command where we do)..
-- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |