lkml.org 
[lkml]   [2007]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [rfc 19/45] cpu alloc: NFS statistics
On Tue, 20 Nov 2007, Mathieu Desnoyers wrote:

> > Index: linux-2.6/fs/nfs/iostat.h
> > ===================================================================
> > --- linux-2.6.orig/fs/nfs/iostat.h 2007-11-15 21:17:24.391404458 -0800
> > +++ linux-2.6/fs/nfs/iostat.h 2007-11-15 21:25:33.167654066 -0800
> > @@ -123,7 +123,7 @@ static inline void nfs_inc_server_stats(
> > int cpu;
> >
> > cpu = get_cpu();
> > - iostats = per_cpu_ptr(server->io_stats, cpu);
> > + iostats = CPU_PTR(server->io_stats, cpu);
> > iostats->events[stat] ++;
>
> Is there a way to change this into a CPU_ADD ?

Yes I must have missed that.

Could be

CPU_INC(server->io_stats->events[stat]);

>
> > put_cpu_no_resched();
>
> Why put_cpu_no_resched here ?

We do not want to reschedule here? We may have already disabled interrupts
or some such thing.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-11-20 21:53    [W:0.111 / U:1.664 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site