lkml.org 
[lkml]   [2007]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 22/29] x86: return correct error code from child_rip in x86_64 entry.S
    2.6.23-stable review patch.  If anyone has any objections, please let us
    know.

    ------------------
    From: Andrey Mirkin <major@openvz.org>

    patch 1c5b5cfd290b6cb7c67020ef420e275f746a7236 in mainline.

    x86: return correct error code from child_rip in x86_64 entry.S

    Right now register edi is just cleared before calling do_exit.
    That is wrong because correct return value will be ignored.
    Value from rax should be copied to rdi instead of clearing edi.

    AK: changed to 32bit move because it's strictly an int

    [ tglx: arch/x86 adaptation ]

    Signed-off-by: Andrey Mirkin <major@openvz.org>
    Signed-off-by: Andi Kleen <ak@suse.de>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86_64/kernel/entry.S | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/x86_64/kernel/entry.S
    +++ b/arch/x86_64/kernel/entry.S
    @@ -989,7 +989,7 @@ child_rip:
    movq %rsi, %rdi
    call *%rax
    # exit
    - xorl %edi, %edi
    + mov %eax, %edi
    call do_exit
    CFI_ENDPROC
    ENDPROC(child_rip)
    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-20 19:39    [W:0.065 / U:70.160 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site