Messages in this thread | | | Subject | Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table | From | Thomas Renninger <> | Date | Tue, 20 Nov 2007 17:48:04 +0100 |
| |
On Tue, 2007-11-20 at 15:31 +0100, Rene Herman wrote: > On 20-11-07 15:19, Thomas Renninger wrote: > > > At the end is some example code how things could get even more cleaned > > up. It shows how I think pnp layer and one example driver would get > > adjusted. There are not that much drivers making use of > > pnp_resource_change... > > The ALSA ISA-PnP drivers do in what I personally consider a bad layering > violation. Brought up not doing that a while ago on alsa-devel, but no > discussion ensued. If the PnP maintainer(s) agree with me though, I'd be > more than happy to rip all of that out of ALSA. > > (added alsa-devel)
The pnp_resource_change is really ugly..., these are making use of it: sound/isa/sb/es968.c sound/isa/sb/sb16.c sound/isa/gus/interwave.c sound/isa/es18xx.c sound/isa/cs423x/cs4236.c sound/isa/wavefront/wavefront.c sound/isa/ad1816a/ad1816a.c sound/isa/cmi8330.c sound/isa/opl3sa2.c sound/isa/opti9xx/opti92x-ad1848.c sound/isa/als100.c sound/isa/azt2320.c sound/isa/dt019x.c
Thomas
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |