Messages in this thread | | | Date | Fri, 2 Nov 2007 20:50:46 +0200 | From | "Ahmed S. Darwish" <> | Subject | Re: [PATCH] Smackv9: Use a stateful parser for parsing Smack rules |
| |
On 11/1/07, Jan Engelhardt <jengelh@computergmbh.de> wrote: > > On Nov 1 2007 17:54, Ahmed S. Darwish wrote: > >+ > >+static inline int isblank(char c) > >+{ > >+ return (c == ' ' || c == '\t'); > >+} > > Use isspace(). >
isspace accepts newlines and carriage-returns too which is not accepted between elements of a one rule.
> >+ for (i = 0; i < count && data[i]; i ++) > >... > >+ subjectstr[(*label_len) ++] = data[i]; > > i++ w/o space >
Notes Taken. Thanks for the review.
Regards,
Darwish - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |