Messages in this thread | | | Date | Fri, 16 Nov 2007 13:46:42 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] proc: use BUG_ON() in de_put() |
| |
On Thu, 15 Nov 2007 19:12:49 +0300 Alexey Dobriyan <adobriyan@sw.ru> wrote:
> It's much more visible that some printk. I still has an unexplained oops > in proc, so let's leave it for a while. > > Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru> > --- > > fs/proc/inode.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > --- a/fs/proc/inode.c > +++ b/fs/proc/inode.c > @@ -37,12 +37,7 @@ void de_put(struct proc_dir_entry *de) > { > if (de) { > lock_kernel(); > - if (!atomic_read(&de->count)) { > - printk("de_put: entry %s already free!\n", de->name); > - unlock_kernel(); > - return; > - } > - > + BUG_ON(atomic_read(&de->count) == 0); > if (atomic_dec_and_test(&de->count)) { > if (de->deleted) { > printk("de_put: deferred delete of %s\n",
I don't see that an error in here _requires_ that we nuke the machine. Surely we can emit a warning and then recover in some fashion?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |