lkml.org 
[lkml]   [2007]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 05/40] hwmon/lm87: Fix a division by zero

    -stable review patch. If anyone has any objections, please let us know.

    ------------------
    From: Jean Delvare <khali@linux-fr.org>

    Already in Linus' tree:
    http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=b965d4b7f614522170af6a7e450be0333792ccd2

    Missing parentheses in the definition of FAN_FROM_REG cause a
    division by zero for a specific register value.

    Signed-off-by: Jean Delvare <khali@linux-fr.org>
    Acked-by: Hans de Goede <j.w.r.degoede@hhs.nl>
    Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/hwmon/lm87.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hwmon/lm87.c
    +++ b/drivers/hwmon/lm87.c
    @@ -129,7 +129,7 @@ static u8 LM87_REG_TEMP_LOW[3] = { 0x3A,
    (((val) < 0 ? (val)-500 : (val)+500) / 1000))

    #define FAN_FROM_REG(reg,div) ((reg) == 255 || (reg) == 0 ? 0 : \
    - 1350000 + (reg)*(div) / 2) / ((reg)*(div))
    + (1350000 + (reg)*(div) / 2) / ((reg)*(div)))
    #define FAN_TO_REG(val,div) ((val)*(div) * 255 <= 1350000 ? 255 : \
    (1350000 + (val)*(div) / 2) / ((val)*(div)))

    --
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-11-15 07:57    [W:0.021 / U:0.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site